Fix TypeScript starter restore failure by stopping pipeline early (Fixes #15420)#15694
Open
michalkalit wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix TypeScript starter restore failure by stopping pipeline early (Fixes #15420)#15694michalkalit wants to merge 1 commit intomicrosoft:mainfrom
michalkalit wants to merge 1 commit intomicrosoft:mainfrom
Conversation
michalkalit
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15694Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15694" |
michalkalit
commented
Mar 29, 2026
| if (appHostProject is not IGuestAppHostSdkGenerator guestProject) | ||
| { | ||
| _interactionService.DisplayError("Automatic 'aspire restore' is unavailable for the new TypeScript starter project because no TypeScript AppHost SDK generator was found."); | ||
| if (Directory.Exists(outputPath)) |
Author
There was a problem hiding this comment.
One thing I’m considering: if the output directory already exists, we shouldn’t delete it on restore failure.
I can update the PR to only delete directories created by the template.
Let me know if you prefer that approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: